Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move insertionPoint state to block-editor store/rename existing insertionPoint to insertionCue #65098

Merged
merged 25 commits into from
Sep 26, 2024
Merged

Move insertionPoint state to block-editor store/rename existing insertionPoint to insertionCue #65098

merged 25 commits into from
Sep 26, 2024

Commits on Sep 25, 2024

  1. Use index instead of insertionIndex

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3e599d2 View commit details
    Browse the repository at this point in the history

  2. Revert "Use index instead of insertionIndex" 

    This reverts commit df849a9.
    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    458c376 View commit details
    Browse the repository at this point in the history

  3. Move/Add inserterInsertionPoint to block editor

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    aae2353 View commit details
    Browse the repository at this point in the history

  4. Update the docs of setIsInserterOpened

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    269fe53 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary props since they won't be set

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b17df45 View commit details
    Browse the repository at this point in the history

  6. Discourage use of rootIndex and insertionIndex on setIsInserterOpened

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2462257 View commit details
    Browse the repository at this point in the history

  7. Remove note

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b06bddd View commit details
    Browse the repository at this point in the history

  8. Use setInserterInsertionPoint in quick inserter

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8136045 View commit details
    Browse the repository at this point in the history

  9. Insert in correct location for root insertions

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a551d83 View commit details
    Browse the repository at this point in the history

  10. Add store tests and improve docs and default state

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a1765fe View commit details
    Browse the repository at this point in the history

  11. Use inserterInsertionPoint for zoom out inserters and zoom out separator

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5959cd8 View commit details
    Browse the repository at this point in the history

  12. Remove blockInsertionPointVisible from zoom out mode inserters

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3705906 View commit details
    Browse the repository at this point in the history

  13. Fix dragging vertical displacement on insertion points

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    72e8309 View commit details
    Browse the repository at this point in the history

  14. Fix inserting at 0 index on zoom out mode

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    355a061 View commit details
    Browse the repository at this point in the history

  15. Fix insertion point at root level

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    136c9a3 View commit details
    Browse the repository at this point in the history

  16. Deprecate rootClientId and insertionIndex on setIsInserterOpened

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    867641e View commit details
    Browse the repository at this point in the history

  17. Renaming Insertion API for clarity 

    - old block-editor insertionPoint becomes insertionCue (for the reducer and state value)
- which opens up insertionPoint to be the real insertion point
- so we can change getInserterInsertionPoint to getInsertionPoint
- rename editor private getInsertionPoint to getInserter to more accurately describe its state
- remove unnecessary deprecation
    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bfff2d4 View commit details
    Browse the repository at this point in the history

  18. Catch missed renamings

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4f262d1 View commit details
    Browse the repository at this point in the history

  19. More renamings and clarification

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    24a2aec View commit details
    Browse the repository at this point in the history

  20. Fix logic and missing private function in editor store

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8d6410c View commit details
    Browse the repository at this point in the history

  21. Fallback to using setInserterIsOpened if already in use

    @jeryj
    jeryj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    28e1596 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Move actions test within reducer to actions test and test with select… 

    …ors as well
    @jeryj
    jeryj committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a21fe77 View commit details
    Browse the repository at this point in the history

  2. Remove unncessary return on dispatch

    @jeryj
    jeryj committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    98cf472 View commit details
    Browse the repository at this point in the history

  3. Update block editor selector state tests from insertionPoint to inser… 

    …tionCue
    @jeryj
    jeryj committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d037772 View commit details
    Browse the repository at this point in the history

  4. Move code back to previous location

    @jeryj
    jeryj committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8c48524 View commit details
    Browse the repository at this point in the history