Style Book: do not use Composite store #65047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -32 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eaf7a18. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10698618119
|
ciampo
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
LGTM and tests well 👍
Something I've noticed is that there's a tab stop between the menu and the style book block examples. Haven't dug deeper, but it looks like it's focusing the iframe itself. This is pre-existing, but something to note and potentially fix.
Yeah, I noticed that too — it was added in #48664 by @andrewserong , who added this paragraph in the PR description:
We can't set
Not sure how solid (and worth our time) this would be. |
|
We could open an issue so it's documented, but I believe this isn't a big priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Extracted from #64723
Do not use Composite's store directly in the Style Book
Why?
See #63704 (comment)
How?
We recently made changes so that:
Compositecomponent accepts the same props asuseCompositeStore;Compositesubcomponents already receive the correctstorewithout need for the consumer to pass it explicitlyTherefore, we can migrate from
to
Testing Instructions
trunk— ie. it is one tab stop, and using up/down arrow keys moves the focus on the other list items. Since the orientation isvertical, using left/right arrow keys should not move focus across the listScreenshots or screencast
Kapture.2024-09-04.at.12.55.03.mp4