Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: document combined fields #64904

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Aug 29, 2024

What?

Improves documentation for the layout property of the view, and adds a section about "Combining fields".

Why?

It's undocumented.

How?

Before After
Trunk This branch
Captura de ecrã 2024-08-29, às 15 02 36 Captura de ecrã 2024-08-29, às 16 59 05
Captura de ecrã 2024-08-29, às 15 03 34

@oandregal oandregal self-assigned this Aug 29, 2024
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@oandregal oandregal added [Type] Developer Documentation Documentation for developers [Package] DataViews /packages/dataviews labels Aug 29, 2024
Copy link

Flaky tests detected in 281233a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10615668568
📝 Reported issues:

@oandregal oandregal merged commit a959d03 into trunk Aug 29, 2024
60 checks passed
@oandregal oandregal deleted the update/dataviews-document-combined-fields branch August 29, 2024 15:22
@github-actions github-actions bot added this to the Gutenberg 19.2 milestone Aug 29, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] DataViews /packages/dataviews [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant