Reusable blocks: fix performance of __experimentalGetAllowedPatterns #64871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @yunvonks, @tloureiro. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
commented
Aug 28, 2024
ellatrix
added
[Type] Performance
ellatrix
commented
Aug 28, 2024
| const pattern = unlock( select( STORE_NAME ) ).getPatternBySlug( | ||
| patternName | ||
| ); | ||
| return pattern ? getParsedPattern( pattern ) : null; |
There was a problem hiding this comment.
This is fine now without memoization, it will always return the same ref.
|
Size Change: -9 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
This was referenced Aug 28, 2024
ellatrix
added
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Aug 29, 2024
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: c7f1e8e |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
The Backport to WP Minor Release label was not removed; removing manually. |
vcanales
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Should fix #64219 and #64732 (which are the same issue I think).
Why?
The editor freezes when there are thousands of reusable blocks.
How?
The problem comes from
__experimentalGetParsedPattern, but more specifically the invalidation functiongetPatternBySlug( patternName ), which in turn usesgetReusableBlocks()in its invalidation function. Normally this should simply return the existing state, but maybe there's more going on in the underlyinggetEntityRecordscall.In any case,
__experimentalGetParsedPatternis a terrible selector. It seems more appropriate to cache the parsed patterns in a weak map, which is what I did here. The performance problems seem to be resolved.Testing Instructions
Add a huge amount of reusable blocks:
Then click around the editor. What I found particularly lagging in not selecting a block but opening the appender. What I tested was the demo content, then click on the first cover and then on the + appender.
Testing Instructions for Keyboard
Screenshots or screencast