Dataviews filter: move resetValueOnSelect prop to combobox item

[ciampo]

What?

Move resetValueOnSelect from Ariakit.Combobox to Ariakit.ComboboxItem

Why?

The resetValueOnSelect prop on Ariakit.Combobox is deprecated since version 0.4.5.

How?

The suggested action is to simply apply it to Ariakit.ComboboxItem instead, which is what this PR does.

Testing Instructions

There shouldn't be any differences at runtime.

• Apply the following diff

Click to expand

diff --git a/packages/dataviews/src/components/dataviews-filters/search-widget.tsx b/packages/dataviews/src/components/dataviews-filters/search-widget.tsx
index 1b369222b8..0cc04f39d6 100644
--- a/packages/dataviews/src/components/dataviews-filters/search-widget.tsx
+++ b/packages/dataviews/src/components/dataviews-filters/search-widget.tsx
@@ -304,6 +304,5 @@ function ComboboxList( { view, filter, onChangeView }: SearchWidgetProps ) {
 }
 
 export default function SearchWidget( props: SearchWidgetProps ) {
-	const Widget = props.filter.elements.length > 10 ? ComboboxList : ListBox;
-	return <Widget { ...props } />;
+	return <ComboboxList { ...props } />;
 }

• Load the "pages" section in the site editor
• Add an "Author" filter
• Type "Ad", select the "Admin" item
• Make sure that the characters that were typed are still there — ie. the input field was not reset.

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ciampo <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[tyxla]

LGTM 👍