Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new section to the SlotFill reference to show how to conditionally render Fills . #64807

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

ryanwelcher
Copy link
Contributor

What?

This PR adds some examples to show how to conditionally render FIlls based on content. ie. Site editor vs post editor

Part of: #64749

Copy link

github-actions bot commented Aug 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ryanwelcher <[email protected]>
Co-authored-by: ndiego <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a minor tweak, but it looks great! 🚢

docs/reference-guides/slotfills/README.md Outdated Show resolved Hide resolved
@ryanwelcher ryanwelcher enabled auto-merge (squash) August 26, 2024 18:16
Copy link

Flaky tests detected in 25639bc.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10564990081
📝 Reported issues:

@ryanwelcher ryanwelcher merged commit b0e7fe2 into trunk Aug 26, 2024
60 checks passed
@ryanwelcher ryanwelcher deleted the feature/add-conditional-rendering-slotfill-docs branch August 26, 2024 18:54
@github-actions github-actions bot added this to the Gutenberg 19.2 milestone Aug 26, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
…lly render Fills . (WordPress#64807)

* Add a conditionally rendering section to slotfill docs.

* Changes per peer review.

* Update docs/reference-guides/slotfills/README.md

Co-authored-by: Nick Diego <[email protected]>

---------

Co-authored-by: Nick Diego <[email protected]>
Co-authored-by: ryanwelcher <[email protected]>
Co-authored-by: ndiego <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants