Shuffle: Don't call '__experimentalGetAllowedPatterns' for every block #64736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Aug 23, 2024
| ! patterns || | ||
| patterns.length === 0 | ||
| ) { | ||
| if ( categories.length === 0 || ! patterns || patterns.length === 0 ) { |
There was a problem hiding this comment.
The categories will always be an array.
Mamaduka
requested review from
youknowriad,
jsnajdr,
tyxla and
jorgefilipecosta
|
I considered adding a check in the |
|
Size Change: +6 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Aug 23, 2024
| const _patterns = __experimentalGetAllowedPatterns( rootBlock ); | ||
| const _patterns = | ||
| _categories.length > 0 | ||
| ? __experimentalGetAllowedPatterns( rootBlock ) |
There was a problem hiding this comment.
It's worth adding a comment why we're doing this, either here or wherever we consume the patterns.
A comment can help in the future if someone is trying to use patterns for something not related to the categories, and they might be confused as to why patterns is empty sometimes.
There was a problem hiding this comment.
Good idea. I added to the comment.
We should also try to improve the __experimentalGetAllowedPatterns performance.
|
Flaky tests detected in d41cf87. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10523227034
|
2 tasks
Mamaduka
added
the
props-bot
github-actions
bot
removed
the
props-bot
Mamaduka
added
the
Backport to Gutenberg RC
artemiomorales
pushed a commit
that referenced
this pull request
Aug 28, 2024
#64736) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: wpsoul <[email protected]>
cbravobernal
added a commit
that referenced
this pull request
Aug 28, 2024
* DataViews: Add missing styles and remove opinionated ones for generic usage (#64711) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jameskoster <[email protected]> * Shuffle: Don't call '__experimentalGetAllowedPatterns' for every block (#64736) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: wpsoul <[email protected]> * DataViews: hide sort direction control if there is no sortable fields (#64817) Co-authored-by: oandregal <[email protected]> Co-authored-by: ntsekouras <[email protected]> * Block Bindings: Refactor utils file. (#64740) * Refactor block binding utils * Add security checks Co-authored-by: cbravobernal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: jsnajdr <[email protected]> * Interactivity API: Fix computeds without scope in Firefox (#64825) * Replace NO_SCOPE symbol with an object * Update changelog Co-authored-by: DAreRodz <[email protected]> Co-authored-by: luisherranz <[email protected]> Co-authored-by: Marc-pi <[email protected]> --------- Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: wpsoul <[email protected]> Co-authored-by: André <[email protected]> Co-authored-by: oandregal <[email protected]> Co-authored-by: Carlos Bravo <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: jsnajdr <[email protected]> Co-authored-by: David Arenas <[email protected]> Co-authored-by: DAreRodz <[email protected]> Co-authored-by: luisherranz <[email protected]> Co-authored-by: Marc-pi <[email protected]>
|
I just cherry-picked this PR to the release/19.1 branch to get it included in the next release: #64876 |
artemiomorales
removed
the
Backport to Gutenberg RC
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
WordPress#64736) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: wpsoul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related #64732.
PR avoids calling the
__experimentalGetAllowedPatternsselector when associated categories aren't available.Why?
When no categories exist, the memo callback returns early, and patterns are unnecessary. Additionally, calling
__experimentalGetAllowedPatternsis expensive - #64219 (comment).Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast