Image block: Add reset button #64669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
Size Change: +42 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
Aug 21, 2024
Mamaduka
approved these changes
Aug 21, 2024
|
Thanks again for the nice work. Should we add the Reset button also to Media & Text? Perhaps even more, is there a way to use the same "media replace" dropdown as a reusable component across all the various pieces? CC: @Mamaduka |
|
I think most core blocks use or should use the |
|
That seems reasonable! If you can add a media item, you should probably also be able to unset it. I assume it'd have the same UI as we're shipping? |
Yeah, we've already consolidated resetting UI; it doesn't make sense to change it now. |
|
Should i create a PR to Implement |
|
I don't think we need an ability to hide the Reset button, but otherwise a PR would be welcome! Thank you. |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
* Add reset button on image block * Update argument on onSelectImage function Co-authored-by: akasunil <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There is no method to reset the image block. You can replace images but not remove them from blocks.
Why?
This PR adds a 'Reset' option to the toggle control that removes the selected image from the image block.
Testing Instructions
Screenshots or screencast
image-block-add-reset-button.webm