Writing Flow: avoid range removal in multi selection and select all #64658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
stokesman
commented
Aug 21, 2024
stokesman
commented
Aug 21, 2024
There was a problem hiding this comment.
removalAllRanges was added in #42711 and I didn’t see mention of what necessitated it. I suppose all of the List block features could use testing? I haven’t found any issues so far.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
stokesman
added
[Type] Bug
|
Closing this because #63671 incidentally fixed the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A naive attempt to fix #64617
Why?
To resolve an issue where a selected container block can become unselected as the window regains focus. This probably hardly ever bothers a human but I have another PR that mysteriously surfaces the issue in E2E tests and that’s what made me aware of it and is the actual motive.
How?
Avoids removing the selection and instead collapses it to the active node.
It seems the reason this works is it avoids a
selectionchangeevent being fired when the window regains focus and thereby avoids theuseSelectionObserverhook moving focus here:gutenberg/packages/block-editor/src/components/writing-flow/use-selection-observer.js
Lines 125 to 144 in b1324c5
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast