Replace instances of deprecated elevation variables #64656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
requested review from
draganescu,
adamziel,
kevin940726,
ellatrix and
geriux
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 9dc871d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10476219774
|
jasmussen
approved these changes
Aug 21, 2024
| @@ -120,7 +120,7 @@ $input-size: 300px; | |||
| } | |||
|
|
|||
| .block-editor-url-input__button-modal { | |||
| box-shadow: $shadow-popover; | |||
| box-shadow: $elevation-x-small; | |||
| border: 1px solid $gray-300; | |||
There was a problem hiding this comment.
Not a blocker, just noticing. Should this be $border-width instead of 1px?
There was a problem hiding this comment.
Yes, there a number of instances of such oversights 😓
Let's open a separate PR to address, hopefully it's a quick find & replace for this one.
artemiomorales
added
the
[Type] Code Quality
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #64108 and #64655
What?
Replace instances of the deprecated
$shadow-popoverand$shadow-modalvariables in the editor.Why?
Code cleanliness. Adoption of elevation scale from the design system.
Testing Instructions
Note
The Gallery block was referencing
$shadow-popoverand applying it to.block-library-gallery-item__inline-menu, but an element with that class doesn't ever seem to render. It may be safe to remove this style entirely, but that's one to handle separately.