Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated @since order in Inline document in client-assets.php file #64653

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Updated @since order in Inline document in client-assets.php file #64653

merged 2 commits into from
Aug 21, 2024

Conversation

shail-mehta
Copy link
Member

@shail-mehta shail-mehta added the [Type] Developer Documentation Documentation for developers label Aug 20, 2024
@shail-mehta shail-mehta self-assigned this Aug 20, 2024
@shail-mehta shail-mehta marked this pull request as draft August 20, 2024 16:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta marked this pull request as ready for review August 20, 2024 16:54
@shail-mehta shail-mehta changed the title Updated Since Order in Inline document in client-assets.php file Updated @since order in Inline document in client-assets.php file Aug 20, 2024
t-hamano
t-hamano approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shail-mehta
Copy link
Member Author

@t-hamano

Is it necessary to include a backport changelog for this PR?

It seems to be failing due to a missing backport changelog.

@t-hamano
Copy link
Contributor

@shail-mehta An equivalent function exists in core here, but the PHP Doc is correct, so I don't think a backport to core or changelog addition is necessary 👍

@t-hamano t-hamano merged commit 18d1752 into trunk Aug 21, 2024
65 of 67 checks passed
@t-hamano t-hamano deleted the update/since-order-in-inline-document branch August 21, 2024 03:14
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 21, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
@shail-mehta @t-hamano @bph
Updated @SInCE order in Inline document in client-assets.php file (Wo…
9f82c10 
…rdPress#64653)

* Updated @SInCE Order in Inline document

* Updated @SInCE Order in Inline document

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@ndiego ndiego Awaiting requested review from ndiego

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy

Assignees

@shail-mehta shail-mehta

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 19.1
Development

Successfully merging this pull request may close these issues.
2 participants
@shail-mehta @t-hamano