Dataviews: Filter icon is displayed even when no filter capabilities are given to any field #64640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fix hides the dropdown button when there are no filter option available to choose from
Why?
Fixes #64631
How?
Added a check if filters are available, if not then return null
Testing Instructions
packages/dataviews/src/components/dataviews/stories/fixtures.js
and comment on any elements or filterBy properties passed in the items passed to the fields propsnpm run storybook:dev
/?path=/story/dataviews-dataviews--default
and check how the filter icon no longer appearsTesting Instructions for Keyboard
Screenshots or screencast
The dropdown button is no longer visible when there are no filter options