Site Editor: Always use auto-cursor style for editable text #64627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +41 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 20, 2024
|
@jasmussen Thanks for the review! |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53374
What?
This PR applies the auto-cursor style whenever the text is editable, i.e., when it's the RichText component.
This makes it possible to tell by the cursor whether the text is editable or not.
Why?
As of #40785, blocks that are non-editable text will now use the default cursor.
However, the block itself is not necessarily a
RichTextcomponent, it may have aRichTextcomponent in it, or it may have an editable block inside it.How?
In addition to applying auto-cursor style when the block itself is editable, this PR also applies auto-cursor to any
RichTextcomponents contained within.Additionally, this PR applies the appropriate cursor style when the block is not selected and is hovered over.
Testing Instructions
Screenshots or screencast
Before
before.mp4
After
after.mp4