Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note about image sizes in MediaUpload::onSelect #64616

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Note about image sizes in MediaUpload::onSelect #64616

merged 1 commit into from
Aug 20, 2024

Conversation

cweiske
Copy link
Contributor

@cweiske cweiske commented Aug 19, 2024

What?

Document that not all image sizes are available when an image has been selected in MediaUpload.

Why?

It is not documented that the available image sizes depend on the original image's resolution.

How?

README is updated

Related: #7483, #7605.

Document that not all image sizes are available when an image has been selected in MediaUpload.
@cweiske cweiske requested a review from ellatrix as a code owner August 19, 2024 14:56
Copy link

github-actions bot commented Aug 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: cweiske <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @cweiske! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 19, 2024
@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers [Package] Block editor /packages/block-editor labels Aug 20, 2024
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Aug 20, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Aug 20, 2024
@Mamaduka Mamaduka merged commit 79340eb into WordPress:trunk Aug 20, 2024
68 of 69 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 20, 2024
@cweiske cweiske deleted the patch-1 branch August 20, 2024 07:39
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
Document that not all image sizes are available when an image has been selected in MediaUpload.

Co-authored-by: cweiske <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Block editor /packages/block-editor [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants