Post Author: Add Border Support #64599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shail-mehta
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +37 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Aug 19, 2024
shail-mehta
force-pushed
the
add/border-support-in-post-author
branch
from
f4d390c to
fcead0e
Compare
aaronrobertshaw
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
LGTM also, thanks @shail-mehta 👍
✅ Global styles apply correctly
✅ Block instance styles override global styles
✅ Styles apply consistently between editor and frontend
✅ Box sizing allows parent to enforce width
✅ Default display of border controls matches spacing controls
Screen.Recording.2024-08-19.at.3.20.56.PM.mp4
|
Thank you both for reviewing this PR. |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
Co-authored-by: shail-mehta <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
97 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add border block support to the
Post Authorblock.Part of #43247
Why?
Post Authorblock is missing border support.How?
Add the border block support in block.json.
Testing Instructions
Post Authorblock's border is Configurable via Global Styles.Post Authorblock and Apply the border Styles.Post Authorblock styles take precedence over global Styles.Post Authorblock borders display correctly in both the Editor and Frontend.Screenshots or Screencast
add-border-support-in-post-author-block.mp4