Background Image: Remove unnecessary 'block-editor' store subscription #64568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
andrewserong
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Oh, good catch, thanks for the reminder about this sort of optimization!
✅ Dragging and dropping on the background image button in the Group block works as before
✅ Dragging and dropping on the background image button in the site wide background image controls works as before
LGTM! 🚀
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +8 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
LGTM Thanks for the clean up 🙇🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is similar to #57554.
PR removes an unnecessary 'block-editor' store subscription from the
BackgroundImageControlscomponent.Why?
The media
mediaUploadsetting is only used during theonFilesDropevent. We can use a static selector getter and grab the setting only when needed.This is a micro-optimization and has little performance impact. It's a good practice to avoid store subscriptions when unnecessary.
Testing Instructions
Testing Instructions for Keyboard
Same.