Comment Author Name: Add Border Support #64550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shail-mehta
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +155 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2730641. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10406584521
|
ramonjd
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
This change appears non-controversial to me. If @aaronrobertshaw (who has had more experience with border block supports than I) doesn't have any issues, then it LGTM!
The author name block already has border support.
Also, the comment author name block has margin and padding support so it complements those.
aaronrobertshaw
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Thanks for the PR and ping 👍
This tests well for me.
✅ Global styles apply correctly
✅ Block instance styles override global styles
✅ Styles apply consistently between the editor and frontend
✅ Box sizing allows for parent to enforce width
✅ Default border control display is consistent with spacing controls
LGTM 🚢
|
Thank you both for the review.🙏 |
97 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add Border support in the
Comment Author Nameblock.Part of #43247
Why?
Comment Author Nameblock is missing border support.How?
Add the border support in block.json.
Testing Instructions
Comment Author Nameblock's border is Configurable via Global Styles.Comment Author NameBlock and Apply the border Styles.Comment Author Nameblock styles take precedence over global Styles.Comment Author Nameblock borders is showing correctly in both the Editor and Frontend.Screenshots or Screencast
add-border-support-in-comment-author-name.mp4