Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add marks to preview size control. #64546

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

jorgefilipecosta
Copy link
Member

Follow up to #64380. cc: @jameskoster

Adds marks to the preview size control.
Screenshot 2024-08-15 at 15 22 50

Testing Instructions

I verified the preview size control works as expected and has the marks.

@jorgefilipecosta jorgefilipecosta added the [Type] Enhancement A suggestion for improvement. label Aug 15, 2024
Copy link

github-actions bot commented Aug 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jorgefilipecosta <[email protected]>
Co-authored-by: jameskoster <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@jameskoster jameskoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works :)

@jorgefilipecosta jorgefilipecosta merged commit 289589c into trunk Aug 15, 2024
49 of 65 checks passed
@jorgefilipecosta jorgefilipecosta deleted the update/add-marks-to-preview-size-control branch August 15, 2024 16:00
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 15, 2024
@artemiomorales artemiomorales added [Package] DataViews /packages/dataviews [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond and removed [Package] DataViews /packages/dataviews labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Package] DataViews /packages/dataviews [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants