Post Author Name: Add Border Support #64530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shail-mehta
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +283 B (+0.02%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Thanks for the PR @shail-mehta 👍
Functionally this works well. I did notice that the PR alters the default display of spacing controls which was a bit unexpected. It also wasn't detailed in the PR description. Was this intended?
✅ Global Styles apply correctly
✅ Block instance styles override global styles
✅ Styles display consistently across editors and frontend
✅ Box sizing allows parent to enforce width
With a tweak to the default controls, I think this should be pretty close.
P.S. My bandwidth and priorities will be shifting somewhat in the near future, so I might not be able to review many block support PRs or respond to pings quickly. Please keep creating as many PRs as you like. They are really helping move the needle on border support adoption 🙇
Even without pinging individuals for review, any submitted PR will get looked at by the broader community.
Noted. I'll take care of this next time. |
aaronrobertshaw
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Thanks for iterating on this one @shail-mehta 👍
✅ Global Styles apply correctly
✅ Block instance styles override global styles
✅ Styles display consistently across editors and frontend
✅ Box sizing allows parent to enforce width
LGTM 🚢
Screen.Recording.2024-08-15.at.4.05.08.PM.mp4
Note: In the video above I had a caching issue preventing the box sizing rule from applying on the frontend. After resolving that it was present and applied.
97 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add border block support to the
Post Author Nameblock.Part of #43247
Why?
Post Author Nameblock is missing border support.How?
Adds the border block support in block.json.
Testing Instructions
Post Author Nameblock's border is Configurable via Global Styles.Post Author Nameblock and Apply the border Styles.Post Author Nameblock styles take precedence over global Styles.Post Author Nameblock borders display correctly in both the Editor and Frontend.Screenshots or Screencast
add-border-support-in-author-name.mp4