-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style engine: update type for getCSSValueFromRawStyle #64528
Conversation
… By default, T is set to string. This allows the function to be flexible with the type of styleValue, but it defaults to handling strings.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Update utils.ts - change type to StyleValue
b42393f
to
44de688
Compare
Flaky tests detected in 44de688. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10399358112
|
What?
Follow up to #64490
Use a generic type parameter
StyleValue
to describe argument and return value ofgetCSSValueFromRawStyle()
.Props to @kevin940726
Why?
Avoid the use of
any
and describe better what the function expects.How?
By default,
StyleValue
is set to string. This allows the function to be flexible with the type of styleValue, but it defaults to handling strings.getCSSValueFromRawStyle()
takes one parameter,styleValue
, which is of typeStyleValue = string
. This means it can be any type, but the function is primarily designed to work with strings.getCSSValueFromRawStyle()
returns a value of the same typeStyleValue
. This ensures that its output type matches its input type.Testing Instructions
The CI should build, all tests should pass.