Add private isZoomOutMode selector
#64503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +43 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 89c62b6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10388756421
|
MaggieCabrera
approved these changes
Aug 14, 2024
getdave
force-pushed
the
add/state-selector-for-zoom-out-mode
branch
from
89c62b6 to
407e3a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a private selector for determining if the currenting editing mode is
zoom-out.Why?
As zoom out is developing and becoming more integral to the editor experience, the codebase is being littered with
__unstableGetEditorMode() === 'zoom-out'calls.This refactors to a standard selector. There is a previous precedent with the
isNavigationModeselector.How?
Create a private selector which can be used to determine whether the editor is in
zoom-outwirthout having to do a string comparison in every instance.Currently private as zoom out is still relatively new and untested.
I haven't done any refactoring of usage because I want buy-in on the selector before I make the effort to do that.
Testing Instructions
Difficult to test as the selector is private.
Testing Instructions for Keyboard
Screenshots or screencast