DataViews Extensibility: Allow unregistering the view post action #64467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This is also the last action to be typed and to allow it to be unregistered by third-parties. Some potential follow-ups:
|
|
Size Change: -90 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
I'm getting the following error on this branch when opening the actions dropdown. Screenshot
|
|
Yes, we were registering a "false" action. It's fixed now. |
Mamaduka
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Thanks, @youknowriad!
P.S. We should probably move this list into the tracking issue.
youknowriad
force-pushed
the
update/view-post-action
branch
2 times, most recently
from
91ee24c to
7060be9
Compare
|
Flaky tests detected in 54b9d7b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10368234191
|
youknowriad
force-pushed
the
update/view-post-action
branch
from
7060be9 to
54b9d7b
Compare
|
I updated the Todo list of the issue. |
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
…4467) Co-authored-by: youknowriad <[email protected]> Co-authored-by: Mamaduka <[email protected]>
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #61084
Similar to #62647
What?
In #62052 an API to register and unregister dataviews actions has been implemented. But in order to allow third-party developers to be able to unregister these actions, we need to be using the same actions in Core to register the core actions. The current PR explore the possibility to use the API to register one action: "view post".
Testing Instructions
1- Open the pages dataviews.
2- You should be able to see the "view post" action in the actions dropdown.
3- you can try to use the action.