DatViews/DataForm: reorganize folders #64378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Code Quality
|
This one would be good to resolve quickly (land or discard), otherwise rebases can be a nightmare. |
|
Size Change: -13 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
I actually don't understand the reasoning for this change. Here's the reasoning for the previous change:
Also noting that a "data view layout" or a "data form layout" is not simply a component, it has things like a label, an icon,... In other words the top level folders are "entities" or actual "concepts". The stuff in I'm not against reorganizing stuff but I don't see any difference between |
The way I see it, a layout doesn't do anything on its own, it's just a component of the whole entity: DataViews or DataForm, which are the high-level entities and actually live in For fields, I'm not opinionated. I'm fine moving it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR reorganizes the folder structure and some naming:
Why?
A few tweaks to improve clarity and findability. The main changes are:
src/dataviews-layoutsandsrc/components/dataviews-layoutsrc/components/dataviews-layoutssrc/components/dataform,src/dataforms-layoutssrc/components/dataform,src/component/dataform-layoutssrc/utilsfolder.How?
Commits:
Testing Instructions
Go to the Pages page and interact with DataViews and DataForm.