DataViews Extensibility: Allow unregistering the duplicate pattern action #64373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +72 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Aug 8, 2024
| @@ -37,7 +37,7 @@ const exportPattern: Action< Pattern > = { | |||
| id: 'export-pattern', | |||
| label: __( 'Export as JSON' ), | |||
| supportsBulk: true, | |||
| isEligible: ( item ) => item.type === 'wp_block', | |||
| isEligible: ( item ) => item.type !== 'wp_template_part', | |||
There was a problem hiding this comment.
This is to relax the check and allow non user patterns to be exported right? I tested a bit and didn't see any issues with this. I'm wondering though why we had that restriction before..
There was a problem hiding this comment.
I think it was probably a mistake that I did before when I ported this action. I don't see why we shouldn't be exporting "theme patterns".
That said, ideally, we should have the same "type" for both theme and user patterns but that's a bigger/separate project.
There was a problem hiding this comment.
Actually there is an issue if you try to import such a pattern afterwards. I remember seeing some logic about __file:pattern during import.
There was a problem hiding this comment.
Interesting, ok, I'll remove that change then.
Mamaduka
reviewed
Aug 8, 2024
Comment on lines
+78
to
+83
| const canCreate = await registry | ||
| .resolveSelect( coreStore ) | ||
| .canUser( 'create', { | ||
| kind: 'postType', | ||
| name: postType, | ||
| } ); |
There was a problem hiding this comment.
This probably needs to be available as part of an item's permissions object.
There was a problem hiding this comment.
I'm not sure to be honest but I can be convinced :P
The permissions are specific to the current item. This is not, this is the ability to create an item.
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
…tion (#64373) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]>
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #61084
Similar to #62647
What?
In #62052 an API to register and unregister dataviews actions has been implemented. But in order to allow third-party developers to be able to unregister these actions, we need to be using the same actions in Core to register the core actions. The current PR explore the possibility to use the API to register one action: "duplicate pattern".
Testing Instructions
1- Open the patterns dataviews.
2- You should be able to see the "duplicate" action in the actions dropdown menu for theme and user patterns.
3- you can try to use the action.