DataViews: abandon the ItemRecord type #64367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I'm happy to go with this. I agree it's a small detail that doesn't have a huge impact. |
youknowriad
approved these changes
Aug 8, 2024
sirreal
reviewed
Aug 8, 2024
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
Co-authored-by: jsnajdr <[email protected]> Co-authored-by: youknowriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a suggestion from #64199 (comment):
ItemRecordtypeField.getValuealways optionalgetValueimplementation, castitemtoanyto prevent type errorsThis greatly simplified the types, at the cost of slightly decreased type safety. Which is very theoretical anyway and IMO has little impact in practice.
Accessing
item[ field.id ]will crash ifitemisundefinedornull. It's true that the types don't prevent that, and that ideally they should. But almost all JS values support the property access operator, including primitives like numbers.