DimensionControl: Add flag to remove bottom margin #64346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
49 tasks
mirka
commented
Aug 7, 2024
Comment on lines
+18
to
+21
| export type DimensionControlProps = Pick< | ||
| SelectControlProps, | ||
| '__next40pxDefaultSize' | '__nextHasNoMarginBottom' | ||
| > & { |
There was a problem hiding this comment.
Not picking other props like value or label because they either have different descriptions or different required settings.
|
Size Change: +8 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Aug 9, 2024
We'll probably be forced to add it once we start throwing deprecation warnings, I'll deal with it later 💅🏻 |
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
* DimensionControl: Add flag to remove bottom margin * Add lint rule * Update in block-editor readme * Add changelog Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38730
What?
Adds a
__nextHasNoMarginBottomprop to DimensionControl to remove the bottom margin.Why?
Better reusability.
How?
Passes through the prop to BaseControl.
Testing Instructions
In the Storybook for DimensionControl, turn on the margin checker tool in the toolbar.