Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide: Add __next40pxDefaultSize to buttons #64181

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Guide: Add __next40pxDefaultSize to buttons #64181

merged 1 commit into from
Aug 2, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Aug 2, 2024

Related to #46741

What?

Change the navigation button of the Guide component to 40px.

Testing Instructions

Test it in one of the following ways:

  • Check on StoryBook
  • Post Editor > Options Menu > Welcome Guide

Screenshots or screencast

Before After
image image

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Aug 2, 2024
@t-hamano t-hamano self-assigned this Aug 2, 2024
@t-hamano t-hamano changed the title Guide: Change button size to 40px Guide: Add __next40pxDefaultSize to buttons Aug 2, 2024
@t-hamano t-hamano requested a review from a team August 2, 2024 03:40
@t-hamano t-hamano marked this pull request as ready for review August 2, 2024 03:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

mirka
mirka approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

tyxla
tyxla approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for helping with #46741 @t-hamano 🙌

@t-hamano t-hamano merged commit eea8d08 into trunk Aug 2, 2024
67 checks passed
@t-hamano t-hamano deleted the guide/40px-default-size branch August 2, 2024 12:35
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Aug 2, 2024
@snyk-io snyk-io bot mentioned this pull request Aug 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirka mirka mirka approved these changes

@tyxla tyxla tyxla approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@t-hamano t-hamano

Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@t-hamano @mirka @tyxla