Update: chevron to home icon. #64161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +93 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Aug 1, 2024
|
I like the premise, but this looks like a checkbox to me 🙊 A radical thought; is the icon even necessary? When you enter the editor the button visibly scales up with intentional animation. Reversing that animation on hover (minimise the button) inherently indicates the behavior (exit the editor). This would simplify the animation effect and circumvent the tricky decisions around which icon to use. |
|
I think an icon help communicate the function better—but we should restore the back filter for site icons, this overlay doesn't work otherwise. |
|
Filter restored here #64172 |
Looking into this after some vacation. I'd agree an icon helps but certainly not this icon.
I'm not sure I understand how a square with rounded corners can ever be mentally associated to the concept of 'home'. The first time I saw this in the editor I thought there was something broken. |
|
Not that far fetched to see how it can be associated with the concept of "home": 
Though I agree it's coming across a bit awkward in that specific context. We should come up with something else. |
That's a convention for one specific brand of devices and mobile OS, not really an universal one. WordPress already has conventions and it does since ages. I'm not sure trying to introduce new, pretty obscure, conventions helps in any way. More importantly, this icon is actually not used to fo to the 'home', which in the case of the Site editor is the WordPress Dashboard. Instead, this icon is actually used to open the Site editor navigation panel. A uch, the iconography in use completely mismatches the functionality and I'm not sure that's any good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #63986 (comment): adds a home button icon to the back flow:
Testing Instructions
Go to the site editor and observe the new home button icon when hovering the site icon.