Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Accordion Block #64119

Open
wants to merge 22 commits into
base: trunk
Choose a base branch
from
Open

Add Accordion Block #64119

wants to merge 22 commits into from
+1,537 −3

Commits on Sep 16, 2024

  1. Add initial accordion implementation.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    fe0aaee View commit details
    Browse the repository at this point in the history

  2. Refactor blocks for core loading.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ebfc5f5 View commit details
    Browse the repository at this point in the history

  3. Simplify state getter by storing id in the context.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c58232f View commit details
    Browse the repository at this point in the history

  4. Clean up tag processing and try to initialize state on the server.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4698eee View commit details
    Browse the repository at this point in the history

  5. Don't enqueue the frontend files if there's no content

    @luisherranz @jffng
    luisherranz authored and jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3c2c54b View commit details
    Browse the repository at this point in the history

  6. Stringify the autoclose value

    @luisherranz @jffng
    luisherranz authored and jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d4101b4 View commit details
    Browse the repository at this point in the history

  7. Refactor to populate context.isOpen on the server

    @luisherranz @jffng
    luisherranz authored and jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    872ecf1 View commit details
    Browse the repository at this point in the history

  8. Add comments to the server side rendering functions.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5f9e24a View commit details
    Browse the repository at this point in the history

  9. Improve the block editing UX 

    - Label the None icon setting
- Add help text to block settings
- Remove button focus styles
- Add border support to the group.
    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b790e90 View commit details
    Browse the repository at this point in the history

  10. Reword the auto-close toggle help text.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7a05993 View commit details
    Browse the repository at this point in the history

  11. Add padding to the content and trigger by default.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    cea68d0 View commit details
    Browse the repository at this point in the history

  12. Fix aria-labelledby and aria-controls references.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    96c37c9 View commit details
    Browse the repository at this point in the history

  13. Allow HeadingLevelOptions to be extended.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    151655b View commit details
    Browse the repository at this point in the history

  14. Only allow bold, italic, image, and strikethrough for the Trigger.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    37315e4 View commit details
    Browse the repository at this point in the history

  15. Disable keyboard navigation for focusable elements when aria-hidden i… 

    …s true.
    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7f17891 View commit details
    Browse the repository at this point in the history

  16. Fix __next40pxDefaultSize linting error.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6c91e72 View commit details
    Browse the repository at this point in the history

  17. Refactor how state and context are initialized to avoid the need for … 

    …a shared function between blocks.
    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    72fdd46 View commit details
    Browse the repository at this point in the history

  18. Use strings for openByDefault so boolean is in the generated JSON.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5967cf1 View commit details
    Browse the repository at this point in the history

  19. Use inert instead of aria-hidden.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    db03ba8 View commit details
    Browse the repository at this point in the history

  20. Rename Trigger and Content to Header and Panel.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    93deeee View commit details
    Browse the repository at this point in the history

  21. Rename interactivity to script modules.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    84112e3 View commit details
    Browse the repository at this point in the history

  22. Remove unused watch directive for setting the tabIndex.

    @jffng
    jffng committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    542ac20 View commit details
    Browse the repository at this point in the history