-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews Extensibility: Allow unregistering permanently delete post action #64088
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
packages/editor/src/dataviews/actions/permanently-delete-post.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { store as coreStore } from '@wordpress/core-data'; | ||
| import { __, sprintf } from '@wordpress/i18n'; | ||
| import { store as noticesStore } from '@wordpress/notices'; | ||
| import type { Action } from '@wordpress/dataviews'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import { getItemTitle, isTemplateOrTemplatePart } from './utils'; | ||
| import type { CoreDataError, PostWithPermissions } from '../types'; | ||
|
|
||
| const permanentlyDeletePost: Action< PostWithPermissions > = { | ||
| id: 'permanently-delete', | ||
| label: __( 'Permanently delete' ), | ||
| supportsBulk: true, | ||
| isEligible( item ) { | ||
| if ( isTemplateOrTemplatePart( item ) || item.type === 'wp_block' ) { | ||
| return false; | ||
| } | ||
| const { status, permissions } = item; | ||
| return status === 'trash' && permissions?.delete; | ||
| }, | ||
| async callback( posts, { registry, onActionPerformed } ) { | ||
| const { createSuccessNotice, createErrorNotice } = | ||
| registry.dispatch( noticesStore ); | ||
| const { deleteEntityRecord } = registry.dispatch( coreStore ); | ||
| const promiseResult = await Promise.allSettled( | ||
| posts.map( ( post ) => { | ||
| return deleteEntityRecord( | ||
| 'postType', | ||
| post.type, | ||
| post.id, | ||
| { force: true }, | ||
| { throwOnError: true } | ||
| ); | ||
| } ) | ||
| ); | ||
| // If all the promises were fulfilled with success. | ||
| if ( promiseResult.every( ( { status } ) => status === 'fulfilled' ) ) { | ||
| let successMessage; | ||
| if ( promiseResult.length === 1 ) { | ||
| successMessage = sprintf( | ||
| /* translators: The posts's title. */ | ||
| __( '"%s" permanently deleted.' ), | ||
| getItemTitle( posts[ 0 ] ) | ||
| ); | ||
| } else { | ||
| successMessage = __( 'The posts were permanently deleted.' ); | ||
| } | ||
| createSuccessNotice( successMessage, { | ||
| type: 'snackbar', | ||
| id: 'permanently-delete-post-action', | ||
| } ); | ||
| onActionPerformed?.( posts ); | ||
| } else { | ||
| // If there was at lease one failure. | ||
| let errorMessage; | ||
| // If we were trying to permanently delete a single post. | ||
| if ( promiseResult.length === 1 ) { | ||
| const typedError = promiseResult[ 0 ] as { | ||
| reason?: CoreDataError; | ||
| }; | ||
| if ( typedError.reason?.message ) { | ||
| errorMessage = typedError.reason.message; | ||
| } else { | ||
| errorMessage = __( | ||
| 'An error occurred while permanently deleting the post.' | ||
| ); | ||
| } | ||
| // If we were trying to permanently delete multiple posts | ||
| } else { | ||
| const errorMessages = new Set(); | ||
| const failedPromises = promiseResult.filter( | ||
| ( { status } ) => status === 'rejected' | ||
| ); | ||
| for ( const failedPromise of failedPromises ) { | ||
| const typedError = failedPromise as { | ||
| reason?: CoreDataError; | ||
| }; | ||
| if ( typedError.reason?.message ) { | ||
| errorMessages.add( typedError.reason.message ); | ||
| } | ||
| } | ||
| if ( errorMessages.size === 0 ) { | ||
| errorMessage = __( | ||
| 'An error occurred while permanently deleting the posts.' | ||
| ); | ||
| } else if ( errorMessages.size === 1 ) { | ||
| errorMessage = sprintf( | ||
| /* translators: %s: an error message */ | ||
| __( | ||
| 'An error occurred while permanently deleting the posts: %s' | ||
| ), | ||
| [ ...errorMessages ][ 0 ] | ||
| ); | ||
| } else { | ||
| errorMessage = sprintf( | ||
| /* translators: %s: a list of comma separated error messages */ | ||
| __( | ||
| 'Some errors occurred while permanently deleting the posts: %s' | ||
| ), | ||
| [ ...errorMessages ].join( ',' ) | ||
| ); | ||
| } | ||
| } | ||
| createErrorNotice( errorMessage, { | ||
| type: 'snackbar', | ||
| } ); | ||
| } | ||
| }, | ||
| }; | ||
|
|
||
| export default permanentlyDeletePost; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this wasn't introduced in this PR, but why do the messages here refer to "posts" and the trash action refers to "items"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess "item" is more generic as we don't really know what the item is.