Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update www.w3.org/2000/svg from http to https #64018

Closed
wants to merge 1 commit into from

Conversation

narenin
Copy link
Contributor

@narenin narenin commented Jul 27, 2024

##Trac Ticket:

https://core.trac.wordpress.org/ticket/61777

What?

This PR will update www.w3.org/2000/svg from http to https because of this in Windows defender Trojan error for wp-includes\dist\block-library\style.min.css

Why?

This PR is necessary because it will Windows defender Trojan error we are getting for wp-includes\dist\block-library\style.min.css

How?

This PR will change http://www.w3.org/2000/svg to https://www.w3.org/2000/svg which will fix the issue.

Testing Instructions

  1. Just downloaded and unpacked the latest version (6.6.1) from https://wordpress.org/download/
  2. windows defender removed wp-includes\dist\block-library\style.min.css stating it was a trojan.

Screenshots or screencast

trac_error

@narenin narenin requested a review from artemiomorales as a code owner July 27, 2024 09:25
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Jul 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: narenin <[email protected]>
Co-authored-by: sabernhardt <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sabernhardt
Copy link
Contributor

Windows Defender should recognize that xmlns is an XML namespace, not a source or a link. The "opaque identifier" needs to remain 'http' for the mask image to be identified as an SVG.

SVG added in #16475

@Otto42
Copy link
Member

Otto42 commented Jul 27, 2024

This is an XML namespace, not a URL. It should not be changed.

@Otto42 Otto42 closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants