Format Library: Polish inline image format popover #64016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +647 B (+0.04%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Good change 👍 Should the button also be 40px, so that it lines up nicely with the input (as it does on trunk)? |
|
Thanks for the review! I changed the button size to
I think
|
|
I don't have a strong feeling, I was mostly curious whether the button + input should be aligned in terms of height, since they are already on trunk. 32px may be fine since the popover is so small. |
|
I don't have a strong opinion either, but 40px is also fine for now. Could we reconsider the size when we try adding the alt textarea in the future? |
jameskoster
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the popover UI for applying widths to inline image.
Why?
The current UI is not consistent compared to other UIs.
How?
I have standardized all sizes and spacing to 8px grid units.
Note: In the future, I aim to add a textarea for
altattribute, as suggested by #63323.Testing Instructions
Insert an inline image and click it.
Screenshots or screencast