-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme JSON: Update core theme json resolver class use to Gutenberg version #63981
Theme JSON: Update core theme json resolver class use to Gutenberg version #63981
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Mukesh Panchal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good to me and everything is testing well. I tested with the dataviews experiment turned on, and Global Styles were correctly displayed in the previews ✅
I also ran the e2e tests locally, and they were all passing and I can see they're passing on this PR (including the font-library.spec.js test!) ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing nicely for me, too!
Thanks for the reviews and getting this one merged while I was away. Appreciate it 🙇 |
What?
Updates some calls to the core
WP_Theme_JSON_Resolver
class with its core equivalent:WP_Theme_JSON_Resolver_Gutenberg
Why?
How?
Append
_Gutenberg
to the core class name.Testing Instructions