Grid layout: Try moving resizer popover slot to fix display on mobile #63920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -4 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
andrewserong
changed the title
|
Just doing a flyby test. Looks pretty good! Kapture.2024-07-25.at.16.23.17.mp4There's a comment about this slot that it's meant for the inline rich text, popover - but that was a while back so maybe not relevant. |
noisysocks
approved these changes
Jul 26, 2024
|
Thanks for confirming, Rob! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #57478, might fix #63275
Similar to #63389, try updating the Grid resizer to use a different popover slot, that is after the editor canvas.
Why?
I noticed that as of #63389, the grid visualizer doesn't erroneously appear on mobile when the list view is open. It seems that if we update the resizer to use the same popover slot, then it'll also no longer appear when the list view is open and a child of a grid block is selected.
Note: I'm not too sure if there are any downsides to this approach, so pinging @noisysocks for a second opinion here 🙂
How?
"__unstable-block-tools-after"slot.childrentoBlockToolshereTesting Instructions
trunkTesting Instructions for Keyboard
Screenshots or screencast