Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Post Edit Screen Restricted by Metaboxes #63914

Conversation

Rishit30G
Copy link
Contributor

What?

Fixes issue: #63882

Why?

Because the metabox on text editor is causing spacing issues

How?

This is solved by adding padding-bottom: 40vh using class block-list-padding-bottom on BlockList component

Testing Instructions

  • Add lot of content to the post
  • Enable Yoast SEO plugin
  • Now we see sufficient space below the text and plugin metabox, like metabox wasn't there

Testing Instructions for Keyboard

Same

Screenshots or screencast

image

Copy link

github-actions bot commented Jul 24, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @CarloCannas.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: CarloCannas.

Co-authored-by: Rishit30G <[email protected]>
Co-authored-by: PC888 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 24, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Rishit30G! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@PC888
Copy link

PC888 commented Jul 25, 2024

Thanks @Rishit30G I just tested again with a completely fresh WP install 6.6.1 and TT4 and the issue persists. It's a terrible editing experience!

@Rishit30G
Copy link
Contributor Author

Hey @PC888,
So sorry to hear that 😞
But as per my understanding and testing, I was able to fix the issue
Please let me know what didn't work

@PC888
Copy link

PC888 commented Jul 25, 2024

Sorry @Rishit30G your fix does appear to resolve the issue...

@CarloCannas
Copy link

Hi, I found this editor behavior annoying too, I'm the one who opened the ticket in core trac.

I did a bit of digging in the code and found out that there's an explicit exclusion that inhibits the standard 40vh margin when there are metaboxes.

https://github.com/WordPress/gutenberg/blob/%40wordpress/edit-post%408.4.0/packages/edit-post/src/components/layout/index.js#L135

I think it would be better to remove that instead of adding some new styles and classes.

@akasunil akasunil added [Type] Bug An existing feature does not function as intended [Feature] Meta Boxes A draggable box shown on the post editing screen labels Jul 25, 2024
@t-hamano
Copy link
Contributor

t-hamano commented Nov 6, 2024

Hi @Rishit30G,

Sorry for the delay in reviewing this PR. This issue has already been resolved by #64639.

I would like to close this PR, but please comment if I missed anything. Thank you for your efforts!

@t-hamano t-hamano closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Meta Boxes A draggable box shown on the post editing screen First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants