Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Add margin support #63547

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Search: Add margin support #63547

merged 1 commit into from
Jul 18, 2024

Conversation

aaronrobertshaw
Copy link
Contributor

Part of: #43241

What?

  • Adopts margin support for the Search block

Why?

  • Offers greater design flexibility
  • Improves consistency in design tooling with other blocks

How?

  • Adopts margin block support

Testing Instructions

  • In the site editor, add a Search block to a page
  • Style via Global Styles and confirm the editor and frontend display correctly
  • Override the global styles on the block instance and confirm they display appropriately in the editor and frontend

Note: Global margins will be overridden by layout whereas block instance margins will not be. There is also an unrelated bug with the spacing visualizers that is being addressed separately.

Screenshots or screencast

Screen.Recording.2024-07-15.at.1.21.04.PM.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Search Affects the Search Block - used to display a search field [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jul 15, 2024
@aaronrobertshaw aaronrobertshaw self-assigned this Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronrobertshaw <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well :) Excited about the consistency

@carolinan
Copy link
Contributor

I am wondering why padding was not added?

@aaronrobertshaw
Copy link
Contributor Author

I am wondering why padding was not added?

Good question, @carolinan 👍

The current color block supports aren't serialized onto the block's wrapper but are instead passed through to the inner button. I wasn't sure how tightly coupled the use case of applying padding is to the ability to define a background color for the entire block.

This PR is a simple step forward that doesn't have to be bogged down around that. We could well decide to just add padding support, for now though I think that can be a follow-up.

@aaronrobertshaw aaronrobertshaw merged commit e842012 into trunk Jul 18, 2024
73 of 74 checks passed
@aaronrobertshaw aaronrobertshaw deleted the add/search-margin-support branch July 18, 2024 06:16
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 18, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Co-authored-by: aaronrobertshaw <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: carolinan <[email protected]>
@annezazu annezazu mentioned this pull request Sep 29, 2024
12 tasks
@fabiankaegy fabiankaegy mentioned this pull request Oct 1, 2024
97 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Search Affects the Search Block - used to display a search field [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants