-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Add margin support #63547
Search: Add margin support #63547
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well :) Excited about the consistency
I am wondering why padding was not added? |
Good question, @carolinan 👍 The current color block supports aren't serialized onto the block's wrapper but are instead passed through to the inner button. I wasn't sure how tightly coupled the use case of applying padding is to the ability to define a background color for the entire block. This PR is a simple step forward that doesn't have to be bogged down around that. We could well decide to just add padding support, for now though I think that can be a follow-up. |
Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: carolinan <[email protected]>
Part of: #43241
What?
Why?
How?
Testing Instructions
Note: Global margins will be overridden by layout whereas block instance margins will not be. There is also an unrelated bug with the spacing visualizers that is being addressed separately.
Screenshots or screencast
Screen.Recording.2024-07-15.at.1.21.04.PM.mp4