-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styles specificity: fix link styles override issue in navigation block #62992
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +11 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Thanks for the speedy PR! Can confirm this works as expected, and would love to see this approved and backported to 6.6 RC2 that is set to come out early in this week. |
@amitraj2203 Thanks for trying to fix this one. There's some discussion on the original issue since you made the PR - #62987 (comment). It looks like this isn't a new issue, the navigation block has had this bug for a while, it was originally reported back in #47431. The styles you've changed the specificity of have a comment above them mentioning that they need higher specificity. The way they've been lowered in your PR unfortunately introduces a regression, you can see it was caught by a couple of failing end to end tests. I'm personally not really sure of the right way to fix this in backward compatible way. 🤔 |
What?
FIxes: #62987
Why?
See this comment
How?
Decreases the specificity of Navigation block link styles
Testing Instructions
1. Add code below into theme.json file.