Styles specificity: allow comment form input overrides #62960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Type] Regression
|
Size Change: +66 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a90f2eb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9710331970
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for the PR! Could you add some steps to test so we can make sure we're all looking at the same problem? 😅 |
ellatrix
added
the
Backport to WP 6.7 Beta/RC
ellatrix
force-pushed
the
fix/comment-form-allow-textarea-overrides
branch
from
a90f2eb
to
fb5da4f
Compare
talldan
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Fixes the immediate issue at hand. To test I updated my theme.json to have the following:
"core/post-comments-form": {
"css": "& textarea, input{border-radius:.33rem; border: 5px solid red;}"
},In trunk I'm seeing the input not receive the border style. In this PR it is.
Knowing that basically any CSS property can be modified with global styles through custom CSS makes me wonder if we should reduce all block styles to 0-1-0.
Yep, I wonder about this too.
gutenbergplugin
pushed a commit
that referenced
this pull request
Jul 9, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: tellthemachines <[email protected]> Co-authored-by: talldan <[email protected]>
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: d995412 |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: tellthemachines <[email protected]> Co-authored-by: talldan <[email protected]>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: tellthemachines <[email protected]> Co-authored-by: talldan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #63049.
See #62679 (comment)
Apparently, global styles allows for overrides with completely custom CSS, which means comment form input and textarea CSS should be possible to override. The problem of course is that the global styles specificity is forced at 0-1-0, while the default styles are higher. This PR lowers them.
Knowing that basically any CSS property can be modified with global styles through custom CSS makes me wonder if we should reduce all block styles to 0-1-0.
Why?
Fixes remaining issue from #62679.
How?
Lower specificity to 0-1-0.
Testing Instructions
Ensure this theme rule works:
Testing Instructions for Keyboard
Screenshots or screencast