Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert autop package to TS #62583

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

up1512001
Copy link
Member

@up1512001 up1512001 commented Jun 14, 2024

What?

This PR converts the autop package to TypeScript.

Why?

Ensures package is fully type checked.

How?

converted files to .ts
added explicit return types for functions .ts files
explicitly typed variables that would otherwise be implicit any

Testing Instructions

npm run test:unit -- packages/autop tests pass
npm run build:package-types returns a zero exit code

reference PR

Closes #61573

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: up1512001 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@sirreal sirreal added [Type] Code Quality Issues or PRs that relate to code quality [Package] Autop /packages/autop labels Jun 14, 2024
@sirreal sirreal enabled auto-merge (squash) June 14, 2024 14:32
@sirreal sirreal merged commit 33c2fb7 into WordPress:trunk Jun 14, 2024
65 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 14, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
Co-authored-by: jpstevens <[email protected]>
Co-authored-by: jsnajdr <[email protected]>
Co-authored-by: sirreal <[email protected]>
Co-authored-by: up1512001 <[email protected]>
@fabiankaegy fabiankaegy mentioned this pull request Oct 1, 2024
97 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Autop /packages/autop [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants