[Mobile] - Fix Inserter items list #62334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Type] Bug
2 tasks
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
geriux
changed the title
added 4 commits
June 10, 2024 10:09
…ct blocks are shown in the inserter
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in a218d83. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9446971640
|
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Mobile - Pass isQuick option to useBlockTypesState for the native inserter * Mobile - Update tests for Buttons and Social Icons to check the correct blocks are shown in the inserter * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR restores the Inserter functionality on mobile.
Why?
After recent changes introduced in #62169 where now all blocks are shown in the inserter, we needed to change this behavior back in mobile since we don't have any categorization at the moment, so it was confusing to show blocks like Social Link or Button after the Core blocks.
How?
By setting the
isQuickparam totruefor theuseBlockTypesStateselector.Testing Instructions
Test case 1 - Social links block
Test case 2 - Buttons block
Test case 3 - Inner blocks
Smoke test inner blocks to double check other blocks can be added, for example in Group, Cover, and Columns blocks.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
InserterBefore.mov
InserterAfter.mov