Use border instead of hr for filtered block list separator #62249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeryj
added
[Feature] Inserter
|
Size Change: +32 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Testing this showed the border works better than the HR. Not sure if we should separate only the insertable at selection from the rest or if every panel should be separated (e.g. most used is not separated from the insertable at next insertion point - which is a list of categories). But that is outside the scope of this PR.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
force-pushed
the
fix/filtered-block-list-separator
branch
from
1846b24
to
f3718a0
Compare
|
Rebasing to see if all the checks will pass. |
ellatrix
added
the
Backport to WP 6.7 Beta/RC
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #62169 as part of #60991
What?
Switches from an hr for a border line to a border bottom in the css.
Why?
Cleanup. Have a thinner line.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast