Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace instances of <13px fonts #6218

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Replace instances of <13px fonts #6218

merged 1 commit into from
Apr 18, 2018

Conversation

jasmussen
Copy link
Contributor

Minimum font size is 13px, or $default-font-size. This PR addresses that, and fixes #5359.

Minimum font size is 13px, or $default-font-size. This PR addresses that, and fixes #5359.
@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Apr 17, 2018
@jasmussen jasmussen self-assigned this Apr 17, 2018
@jasmussen jasmussen requested a review from a team April 17, 2018 08:59
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👌📈🔥👍💯

@jasmussen
Copy link
Contributor Author

Thanks for the review and all the emoji! :D

The [type=text] addition to the input field was actually to fix a specificity issue that regressed previously as part of an input field overhaul.

@jasmussen jasmussen merged commit 397c853 into master Apr 18, 2018
@jasmussen jasmussen deleted the fix/5359 branch April 18, 2018 05:14
nuzzio pushed a commit to nuzzio/gutenberg that referenced this pull request Apr 25, 2018
Minimum font size is 13px, or $default-font-size. This PR addresses that, and fixes WordPress#5359.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS: audit the font-size and consider a bigger minimum size
2 participants