Block Editor: Check for multiple block usage in the block-editor package #62086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -309 B (-0.02%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/move-multiple-usage-to-block-editor
branch
from
923bf2f to
276e906
Compare
ellatrix
reviewed
May 29, 2024
| onReplace, | ||
| } ) { | ||
| const { selectBlock } = useDispatch( blockEditorStore ); | ||
| const blockType = getBlockType( name ); |
ellatrix
reviewed
May 29, 2024
| @@ -49,6 +53,7 @@ export default function BlockEdit( { | |||
| const layoutSupport = | |||
| hasBlockSupport( name, 'layout', false ) || | |||
| hasBlockSupport( name, '__experimentalLayout', false ); | |||
| const originalBlockClientId = useOriginalBlockOnlyUseOnce( clientId ); | |||
There was a problem hiding this comment.
Not sure I like this, we are adding another block-editor subscription. Could you move this to the private context provider where we select all the needed data for a block?
There was a problem hiding this comment.
We can :) just noting that we were already doing this though.
There was a problem hiding this comment.
Let me know if I did it properly.
ellatrix
approved these changes
May 29, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…age (WordPress#62086) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]>
costasovo
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Jun 5, 2024
The code was commented because it was breaking the build after dependencies update. The functionality is now directly included in the block editor so we can safely remove the code. See WordPress/gutenberg#62086 [MAILPOET-6054]
costasovo
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Jun 7, 2024
The code was commented because it was breaking the build after dependencies update. The functionality is now directly included in the block editor so we can safely remove the code. See WordPress/gutenberg#62086 [MAILPOET-6054]
costasovo
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Jun 10, 2024
The code was commented because it was breaking the build after dependencies update. The functionality is now directly included in the block editor so we can safely remove the code. See WordPress/gutenberg#62086 [MAILPOET-6054]
costasovo
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Jun 10, 2024
The code was commented because it was breaking the build after dependencies update. The functionality is now directly included in the block editor so we can safely remove the code. See WordPress/gutenberg#62086 [MAILPOET-6054]
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…age (WordPress#62086) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]>
Aschepikov
pushed a commit
to mailpoet/mailpoet
that referenced
this pull request
Jun 17, 2024
The code was commented because it was breaking the build after dependencies update. The functionality is now directly included in the block editor so we can safely remove the code. See WordPress/gutenberg#62086 [MAILPOET-6054]
This was referenced Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
While navigating the post editor code base, I noticed that we have some code that shows a warning when a block that doesn't allow multiple usage is used more than once.
That said, this code has nothing specific to the post editor and should be something that is bundled in the block-editor package to work in all contexts (like the site editor).
Testing instructions
1- Create a page with a "more" block.
2- Copy/paste the block to insert it twice
3- Notice the warning message
4- Save the page and open it in the site editor
5- The warning should still be visible.