Editor: Unify text/code editor between post and site editors #61934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
May 24, 2024
| @@ -22,7 +22,7 @@ import { store as editPostStore } from '../../store'; | |||
| import { unlock } from '../../lock-unlock'; | |||
| import { usePaddingAppender } from './use-padding-appender'; | |||
|
|
|||
| const { EditorCanvas } = unlock( editorPrivateApis ); | |||
| const { VisualEditor: VisualEditorRoot } = unlock( editorPrivateApis ); | |||
There was a problem hiding this comment.
This PR includes a rename to this component as it's clearer this way. The canvas can hold both code and visual editors but what we used to call "canvas" represents just the visual editor actually.
|
Size Change: -3.09 kB (-0.18%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…ss#61934) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: bacoords <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…ss#61934) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: bacoords <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
Also closes #61731
What?
This PR moves the code editor component from the post editor to the editor package and reuses the same component in the site editor package avoiding duplication and fixing the bug mentioned in #61731
Testing Instructions
1- The code editor in the post editor should continue to work properly.
2- In the site editor, when opening pages, the code editor allows you to actually edit the code of the page instead of the template.