fix make dimensions.aspectRatios key of theme.json files translatable

[fabiankaegy]

What?

Make Aspect Ratio preset names in theme.json translatable.

Why?

Closing #61767

How?

Adding the schema to the theme-i18n.json file.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: ajlende <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[fabiankaegy]

@swissspidy I also updated the PR in core to include this: WordPress/wordpress-develop@ddc6877

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/theme-i18n.json

[Mamaduka]

@fabiankaegy, @swissspidy, what are the testing instructions for theme-i18n.json changes?

[fabiankaegy]

@Mamaduka I am unsure myself sadly. I just followed the code examples and looked at a few other PR's that implemented it

[swissspidy]

Manually updating translation files & then verifying that the strings are transkated woukd be one option.

[t-hamano]

If I understand correctly, theme-i18n.json exists to make preset labels translatable, right?

I tried testing existing presets, but for some reason they don't translate.

For example, color presets are translated into Japanese on GlotPress:

https://translate.wordpress.org/projects/wp-themes/twentytwentyfour/ja/default/?filters%5Bterm%5D=Accent&filters%5Bterm_scope%5D=scope_originals&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filters%5Buser_login%5D=&filter=Apply+Filters&sort%5Bby%5D=original&sort%5Bhow%5D=asc

But when I change the site language to Japanese, the color palette is not translated 🤔

[ajlende]

As far as I'm aware, this is the only setting that should control i18n for theme.json. I'm going to get this merged for the 18.4 release, but I think it's worthwhile looking into the issue of it not working even for the pre-existing color palette that @t-hamano shared above.

[github-actions]

Flaky tests detected in 6d89977.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9198731152
📝 Reported issues:

• [Flaky Test] Clicking on inserter while on zoom-out should open the patterns tab on the inserter #61806 in /test/e2e/specs/site-editor/zoom-out.spec.js

[ajlende]

I just cherry-picked this PR to the release/18.4 branch to get it included in the next release: 5d68089

[ellatrix]

Thank you ❤️

[ellatrix]

This needs to be backported?