-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSDoc to PostVisibility, PostVisibilityCheck, and PostVisibilityLabel #61735
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @dbrian! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Co-authored-by: dbrian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of small comments, but this looks good. Thanks!
* @param {string} props.label - The label for the visibility option. | ||
* @param {string} props.info - Additional information about the visibility option. | ||
* @return {JSX.Element} The rendered component. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not exported so we could leave it as is, though it doesn't hurt to have it 😄 .
@@ -17,6 +17,15 @@ import { __experimentalInspectorPopoverHeader as InspectorPopoverHeader } from ' | |||
import { visibilityOptions } from './utils'; | |||
import { store as editorStore } from '../../store'; | |||
|
|||
/** | |||
* PostVisibility component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove this PostVisibility component.
from every component because the generated docs include the component's name, so it's kind of duplicate..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…abel (WordPress#61735) Co-authored-by: dbrian <[email protected]> Co-authored-by: colorful-tones <[email protected]> Co-authored-by: ntsekouras <[email protected]>
What?
Part of: #60358
This PR adds JSDoc comments to the PostVisibility, PostVisibilityCheck, and PostVisibilityLabel to improve code documentation and maintainability.