Interactivity API: No implicit any

packages/interactivity/src/hooks.tsx

@@ -140,6 +140,7 @@
  * @return The context content.
  */
 export const getContext = < T extends object >( namespace?: string ): T =>
+	// @ts-expect-error it's any!
 	getScope()?.context[ namespace || getNamespace() ];
 
 /**
@@ -281,7 +282,7 @@
 	}
 	const current = {
 		...resolvedStore,
 		context: getScope().context[ namespace ],
 	};
 	try {
 		// TODO: Support lazy/dynamically initialized stores
@@ -326,7 +327,7 @@
 };
 
 // Component that wraps each priority level of directives of an element.
 const Directives = ( {
 	directives,
 	priorityLevels: [ currentPriorityLevel, ...nextPriorityLevels ],
 	element,
@@ -349,7 +350,7 @@
 	scope.attributes = element.props;
 
 	// Recursively render the wrapper for the next priority level.
 	const children =
 		nextPriorityLevels.length > 0
 			? createElement( Directives, {
 					directives,
@@ -360,7 +361,7 @@
 			  } )
 			: element;
 
 	const props = { ...originalProps, children };
 	const directiveArgs = {
 		directives,
 		props,
@@ -391,7 +392,7 @@
 		const directives = props.__directives;
 		if ( directives.key ) {
 			vnode.key = directives.key.find(
 				( { suffix } ) => suffix === 'default'
 			).value;
 		}
 		delete props.__directives;

packages/interactivity/src/index.ts

@@ -32,7 +32,9 @@ export { useState, useRef } from 'preact/hooks';
 const requiredConsent =
 	'I acknowledge that using private APIs means my theme or plugin will inevitably break in the next version of WordPress.';
 
-export const privateApis = ( lock ): any => {
+export const privateApis = ( _lock: string ): any => {
+	// This is a public API - provide type input about the parameter but don't trust it.
+	const lock: unknown = _lock;
 	if ( lock === requiredConsent ) {
 		return {
 			directivePrefix,

packages/interactivity/src/vdom.ts

@@ -139,26 +139,31 @@ export function toVdom( root: Node ): Array< ComponentChild > {
 		}
 
 		if ( directives.length ) {
-			props.__directives = directives.reduce(
-				( obj, [ name, ns, value ] ) => {
-					const directiveMatch = directiveParser.exec( name );
-					if ( directiveMatch === null ) {
-						warn( `Found malformed directive name: ${ name }.` );
-						return obj;
-					}
-					const prefix = directiveMatch[ 1 ] || '';
-					const suffix = directiveMatch[ 2 ] || 'default';
-
-					obj[ prefix ] = obj[ prefix ] || [];
-					obj[ prefix ].push( {
-						namespace: ns ?? currentNamespace(),
-						value,
-						suffix,
-					} );
-					return obj;
-				},
-				{}
-			);
+			const directivesProp: Record<
+				string,
+				Array< {
+					namespace: string | null;
+					value: unknown;
+					suffix: string;
+				} >
+			> = {};
+			for ( const [ name, ns, value ] of directives ) {
+				const directiveMatch = directiveParser.exec( name );
+				if ( directiveMatch === null ) {
+					warn( `Found malformed directive name: ${ name }.` );
+					continue;
+				}
+				const prefix = directiveMatch[ 1 ] || '';
+				const suffix = directiveMatch[ 2 ] || 'default';
+
+				directivesProp[ prefix ] = directivesProp[ prefix ] || [];
+				directivesProp[ prefix ].push( {
+					namespace: ns ?? currentNamespace(),
+					value,
+					suffix,
+				} );
+			}
+			props.__directives = directivesProp;
 		}
 
 		// @ts-expect-error Fixed in upcoming preact release https://github.com/preactjs/preact/pull/4334

packages/interactivity/tsconfig.json

@@ -4,8 +4,7 @@
 	"compilerOptions": {
 		"rootDir": "src",
 		"declarationDir": "build-types",
-
-		"noImplicitAny": false
+		"types": [ "gutenberg-env" ]
 	},
 	"include": [ "src/**/*" ]
 }