Post Actions: Correctly disable dropdown trigger #61625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +2 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
May 14, 2024
| @@ -52,6 +52,7 @@ export default function PostActions( { onActionPerformed, buttonProps } ) { | |||
| icon={ moreVertical } | |||
| label={ __( 'Actions' ) } | |||
| disabled={ ! actions.length } | |||
| __experimentalIsFocusable | |||
There was a problem hiding this comment.
When can we make this the default behavior for buttons?
There was a problem hiding this comment.
That is mentioned in the tracking issue, but there’s no final decision.
youknowriad
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR makes sure that the "Post Actions" dropdown trigger is focusable even when disabled.
Why?
See #56547.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshot