Zoomed Out View: Don't close the inserter #61004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -5 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
This will affect every editing mode, not only the Zoomed-out. It also changes the Inserter's already established/expected behavior, so it would be nice to get more general feedback. cc @WordPress/gutenberg-core |
|
I have a similar PR that preserves the Escape keypress to close the sidebar. Maybe we can remove the Escape keypress though to close the inserter though since it would be a persistent sidebar. #60391 |
|
Let's also add the X button to the now-persistent sidebar. To make room, we can move the search field to be the first element within each tab section. |
|
I agree with this PR, and I think it does make sense for non zoom out modes as well. However, I think the second panel should still close when I click inside the content, as it overlaps the content? Maybe that means only the second panel should become a dialog? 
|
Zoom out should be engaged when a category is selected, as it is in the site editor; it's just not updated to the same behavior in the post editor yet. |
But the media tab also has a second panel. |
Yes, I'd suggest the same behavior for the media's categories as well. |
|
@scruffian I made an attempt to move the search inside the block and pattern tabs and also make it contextual to the block/pattern tab. The code is definitely not in a good place, but it does allow us to play around with the feel of it. Feel free to revert to keep going with it. |
Otherwise, this is what we get:
|
Just a quick echo that this path also feels very valid from a quick check. |
@scruffian Do you have that screenshot? |
scruffian
force-pushed
the
update/leave-inserter-open
branch
2 times, most recently
from
cb4cc71
to
555aee9
Compare
scruffian
force-pushed
the
update/leave-inserter-open
branch
from
555aee9
to
5b078d2
Compare
This was referenced May 8, 2024
|
Noting that to my understanding this PR introduced two regressions that are now addressed by #61467 |
This was referenced May 8, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make the inserter not a dialog anymore so that it doesn't close when we focus outside of it.
Why?
The other sidebar panels don't operate as dialogs, so this brings consistency with them
How?
Just remove the
useDialoghook from the component.Testing Instructions
Screenshots or screencast
Apr-23-2024.15-53-36.mp4