Fix safari bug with classes not being added to iframe elements #60550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +52 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Apr 8, 2024
ellatrix
reviewed
Apr 8, 2024
glendaviesnz
changed the title
oh, that would be helpful! 😄 I can't find anything specific in the webkit bug tracker, and there are just a few vague references to it on the odd stack overflow post.
Yep, me too. I have 🤞 that there is an alternative to the retry, but haven't had much luck trying to find one so far. I can't see that we are doing something obviously wrong here. In Safari's case it is like we need an onload listener on node.contentDocument instead, or using |
|
Have also tried: and for Safari node.contentDocument.body is regularly |
|
@glendaviesnz We shouldn't check the iframe body because we actually remove that ourselves. That's because we render the body with React and need to avoid two body elements. So we should remove all this logic introduced last week here because it's not possible to have initial body classes: If you remove that logic, it will fix the error, and your issue. |
This was referenced Apr 9, 2024
|
thanks for the follow up @ellatrix. Closing this in favour of #60616 I think the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Often in Safari the correct styles are not applied to the editor iframe elements. This currently only shows itself in zoomed out mode as the
.block-editor-iframe__htmlclass is not applied, so the required transformation styles to make zoomed out mode work are not applied.You might need to refresh the browser several times to see the issue, it does not happen with every load.
Why?
Sometimes Safari fires the load event before
contentDocumentis properly loaded in the iFrame, so acontentDocument.bodyis null exception is thrown and the correct classes are not applied.How?
Checks that
contentDocument.body !== nulland if it is runonLoadagain after a timeout.Testing Instructions
Screenshots or screencast
Before:
zoom-before.mp4
After:
zoom-after.mov